From 5f561f1d961246a38f848c8b96d9c3b6d22b5967 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Valverd=C3=A9?= <julien.valverde@mailo.com>
Date: Sun, 10 Aug 2025 18:30:45 +0200
Subject: [PATCH] Input tests

---
 packages/example/src/lib/TextAreaInput.tsx  | 45 +++++++++++++++++++++
 packages/example/src/lib/TextFieldInput.tsx | 21 +++++-----
 packages/example/src/todo/Todo.tsx          | 25 ++++--------
 3 files changed, 62 insertions(+), 29 deletions(-)
 create mode 100644 packages/example/src/lib/TextAreaInput.tsx

diff --git a/packages/example/src/lib/TextAreaInput.tsx b/packages/example/src/lib/TextAreaInput.tsx
new file mode 100644
index 0000000..4893148
--- /dev/null
+++ b/packages/example/src/lib/TextAreaInput.tsx
@@ -0,0 +1,45 @@
+import { Callout, Flex, TextArea, TextAreaProps } from "@radix-ui/themes"
+import { Option, ParseResult, Schema, Struct } from "effect"
+import { Component } from "effect-fc"
+import { useInput } from "effect-fc/hooks"
+import * as React from "react"
+
+
+export interface TextAreaInputProps<A, R>
+extends
+    Omit<useInput.Options<A, R>, "schema">,
+    Omit<TextAreaProps, "ref">
+{}
+
+export const TextAreaInput = <A, R>(
+    schema: Schema.Schema<A, string, R>
+): Component.Component<
+    TextAreaInputProps<A, R>,
+    React.JSX.Element,
+    ParseResult.ParseError,
+    R
+> => Component.makeUntraced(function* TextFieldInput(props) {
+    const input = yield* useInput({ schema, ...props })
+    const issues = React.useMemo(() => Option.map(
+        input.error,
+        ParseResult.ArrayFormatter.formatErrorSync,
+    ), [input.error])
+
+    return (
+        <Flex direction="column" gap="1">
+            {Option.isSome(issues) &&
+                <Callout.Root color="red" role="alert">
+                    <Callout.Text>
+                        <ul>{issues.value.map((issue, i) => <li key={i}>{issue.message}</li>)}</ul>
+                    </Callout.Text>
+                </Callout.Root>
+            }
+
+            <TextArea
+                value={input.value}
+                onChange={input.onChange}
+                {...Struct.omit(props, "ref")}
+            />
+        </Flex>
+    )
+})
diff --git a/packages/example/src/lib/TextFieldInput.tsx b/packages/example/src/lib/TextFieldInput.tsx
index ee31939..9e3d45a 100644
--- a/packages/example/src/lib/TextFieldInput.tsx
+++ b/packages/example/src/lib/TextFieldInput.tsx
@@ -1,14 +1,15 @@
 import { Callout, Flex, TextField } from "@radix-ui/themes"
-import { Option, ParseResult, Schema } from "effect"
+import { Option, ParseResult, Schema, Struct } from "effect"
 import { Component } from "effect-fc"
 import { useInput } from "effect-fc/hooks"
 import * as React from "react"
 
 
-export interface TextFieldInputProps<A, R> extends Omit<useInput.Options<A, R>, "schema"> {
-    readonly textFieldRootProps: Omit<TextField.RootProps, "children">
-    readonly children?: React.ReactNode
-}
+export interface TextFieldInputProps<A, R>
+extends
+    Omit<useInput.Options<A, R>, "schema">,
+    Omit<TextField.RootProps, "ref">
+{}
 
 export const TextFieldInput = <A, R>(
     schema: Schema.Schema<A, string, R>
@@ -29,9 +30,7 @@ export const TextFieldInput = <A, R>(
             {Option.isSome(issues) &&
                 <Callout.Root color="red" role="alert">
                     <Callout.Text>
-                        <ul>
-                            {issues.value.map(issue => <li>{issue.message}</li>)}
-                        </ul>
+                        <ul>{issues.value.map((issue, i) => <li key={i}>{issue.message}</li>)}</ul>
                     </Callout.Text>
                 </Callout.Root>
             }
@@ -39,10 +38,8 @@ export const TextFieldInput = <A, R>(
             <TextField.Root
                 value={input.value}
                 onChange={input.onChange}
-                {...props.textFieldRootProps}
-            >
-                {props.children}
-            </TextField.Root>
+                {...Struct.omit(props, "ref")}
+            />
         </Flex>
     )
 })
diff --git a/packages/example/src/todo/Todo.tsx b/packages/example/src/todo/Todo.tsx
index 89ad896..8281053 100644
--- a/packages/example/src/todo/Todo.tsx
+++ b/packages/example/src/todo/Todo.tsx
@@ -1,7 +1,8 @@
 import * as Domain from "@/domain"
-import { Box, Button, Callout, Flex, IconButton, Text, TextArea } from "@radix-ui/themes"
+import { TextAreaInput } from "@/lib/TextAreaInput"
+import { Box, Button, Flex, IconButton } from "@radix-ui/themes"
 import { GetRandomValues, makeUuid4 } from "@typed/id"
-import { Chunk, Effect, Match, Option, ParseResult, Ref, Runtime, Schema, SubscriptionRef } from "effect"
+import { Chunk, Effect, Match, Option, Ref, Runtime, Schema, SubscriptionRef } from "effect"
 import { Component, Memo } from "effect-fc"
 import { Hooks } from "effect-fc/hooks"
 import { SubscriptionSubRef } from "effect-fc/types"
@@ -10,6 +11,8 @@ import { FaDeleteLeft } from "react-icons/fa6"
 import { TodosState } from "./TodosState.service"
 
 
+const StringTextAreaInput = TextAreaInput(Schema.String)
+
 const makeTodo = makeUuid4.pipe(
     Effect.map(id => Domain.Todo.Todo.make({
         id,
@@ -41,26 +44,14 @@ export class Todo extends Component.makeUntraced(function* Todo(props: TodoProps
     ), [props._tag, props.index])
 
     const [size] = yield* Hooks.useSubscribeRefs(state.sizeRef)
-    const contentInput = yield* Hooks.useInput({ ref: contentRef, schema: Schema.Any })
+
+    const StringTextAreaInputFC = yield* StringTextAreaInput
 
     return (
         <Flex direction="column" align="stretch" gap="2">
-            {Option.isSome(contentInput.error) &&
-                <Callout.Root color="red">
-                    <Callout.Text>
-                        {ParseResult.ArrayFormatter.formatErrorSync(contentInput.error.value).map(e => <>
-                            <Text>&bull; {e.message}</Text><br />
-                        </>)}
-                    </Callout.Text>
-                </Callout.Root>
-            }
-
             <Flex direction="row" align="center" gap="2">
                 <Box flexGrow="1">
-                    <TextArea
-                        value={contentInput.value}
-                        onChange={contentInput.onChange}
-                    />
+                    <StringTextAreaInputFC ref={contentRef} />
                 </Box>
 
                 {props._tag === "edit" &&