From d02864b873acd07deb75caf928d1e271201dd4c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julien=20Valverd=C3=A9?= Date: Fri, 2 Jan 2026 21:31:15 +0100 Subject: [PATCH] Fix --- packages/example/src/TestUi1Component.tsx | 2 +- packages/react-godot-renderer/src/Component.ts | 9 +-------- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/packages/example/src/TestUi1Component.tsx b/packages/example/src/TestUi1Component.tsx index a79e1d1..26c01be 100644 --- a/packages/example/src/TestUi1Component.tsx +++ b/packages/example/src/TestUi1Component.tsx @@ -20,7 +20,7 @@ export function TestUi1Component() { Component.useSignal(buttonRef, "pressed", () => { console.log("Pressed!") }) - const [buttonPressed] = Component.useSignalValues(buttonRef, "toggled", () => [false] as const) + const [buttonPressed] = Component.useSignalValues(buttonRef, "toggled", [false]) return ( diff --git a/packages/react-godot-renderer/src/Component.ts b/packages/react-godot-renderer/src/Component.ts index 067076f..5996cff 100644 --- a/packages/react-godot-renderer/src/Component.ts +++ b/packages/react-godot-renderer/src/Component.ts @@ -100,13 +100,6 @@ export const useSignalValues = , A exten | (() => useSignalValues.SignalValues, NoInfer>), ): useSignalValues.SignalValues => { const [values, setValues] = React.useState(initialValue) - React.useEffect(() => { - if (!ref.current) return - const signal = ref.current[name] as Godot.Signal - const callable = Godot.Callable.create(setValues) - signal.connect(callable) - return () => { signal.disconnect(callable) } - }, [ref.current, name]) - + useSignal(ref, name, ((...args: any) => setValues(args)) as any) return values }