From 1ec3e616bb2179a27f8324985d504c623d857d36 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julien=20Valverd=C3=A9?= Date: Sun, 19 Jan 2025 00:33:42 +0100 Subject: [PATCH] Tests --- packages/reffuse/src/Reffuse.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/reffuse/src/Reffuse.ts b/packages/reffuse/src/Reffuse.ts index dc1c6c6..bc9fe8b 100644 --- a/packages/reffuse/src/Reffuse.ts +++ b/packages/reffuse/src/Reffuse.ts @@ -57,6 +57,8 @@ export class Reffuse { /** + * ⚠️ Scope closing on cleanup is currently broken when using React strict mode! ⚠️ + * * Reffuse equivalent to `React.useMemo`. * * `useMemo` will only recompute the memoized value by running the given synchronous effect when one of the deps has changed. \ @@ -87,7 +89,7 @@ export class Reffuse { React.useEffect(() => { console.log("effect", value, scope) - // return () => { console.log("cleanup", value, scope); runSync(Scope.close(scope, Exit.void)) } + return () => { console.log("cleanup", value, scope); runSync(Scope.close(scope, Exit.void)) } }, [scope]) return value