From 58b2da373e9945c7b37aa5820c488ab7dba82378 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20Valverd=C3=A9?= <julien.valverde@mailo.com>
Date: Sat, 24 May 2025 21:04:01 +0200
Subject: [PATCH] Query refactoring

---
 packages/extension-query/src/QueryRunner.ts  | 33 ++++++++++----------
 packages/extension-query/src/QueryService.ts |  7 -----
 packages/extension-query/src/index.ts        |  1 -
 3 files changed, 17 insertions(+), 24 deletions(-)
 delete mode 100644 packages/extension-query/src/QueryService.ts

diff --git a/packages/extension-query/src/QueryRunner.ts b/packages/extension-query/src/QueryRunner.ts
index d1b372b..c98eacd 100644
--- a/packages/extension-query/src/QueryRunner.ts
+++ b/packages/extension-query/src/QueryRunner.ts
@@ -7,6 +7,7 @@ import { QueryState } from "./internal/index.js"
 
 
 export interface QueryRunner<K extends readonly unknown[], A, E> {
+    readonly queryKey: Stream.Stream<K>
     readonly latestKeyRef: SubscriptionRef.SubscriptionRef<Option.Option<K>>
     readonly stateRef: SubscriptionRef.SubscriptionRef<AsyncData.AsyncData<A, E>>
     readonly fiberRef: SubscriptionRef.SubscriptionRef<Option.Option<Fiber.RuntimeFiber<
@@ -14,7 +15,8 @@ export interface QueryRunner<K extends readonly unknown[], A, E> {
         Cause.NoSuchElementException
     >>>
 
-    readonly forkInterrupt: Effect.Effect<Fiber.RuntimeFiber<void, Cause.NoSuchElementException>>
+    readonly interrupt: Effect.Effect<void>
+    readonly forkInterrupt: Effect.Effect<Fiber.RuntimeFiber<void>>
     readonly forkFetch: Effect.Effect<readonly [
         fiber: Fiber.RuntimeFiber<AsyncData.Success<A> | AsyncData.Failure<E>, Cause.NoSuchElementException>,
         state: Stream.Stream<AsyncData.AsyncData<A, E>>,
@@ -23,11 +25,14 @@ export interface QueryRunner<K extends readonly unknown[], A, E> {
         fiber: Fiber.RuntimeFiber<AsyncData.Success<A> | AsyncData.Failure<E>, Cause.NoSuchElementException>,
         state: Stream.Stream<AsyncData.AsyncData<A, E>>,
     ]>
-
-    readonly fetchOnKeyChange: Effect.Effect<void, Cause.NoSuchElementException, Scope.Scope>
 }
 
 
+export const Tag = <const Id extends string>(id: Id) => <
+    Self, K extends readonly unknown[], A, E = never
+>() => Effect.Tag(id)<Self, QueryRunner<K, A, E>>()
+
+
 export interface MakeProps<K extends readonly unknown[], A, FallbackA, E, HandledE, R> {
     readonly QueryClient: QueryClient.GenericTagClass<FallbackA, HandledE>
     readonly key: Stream.Stream<K>
@@ -158,26 +163,16 @@ export const make = <K extends readonly unknown[], A, FallbackA, E, HandledE, R>
         ))
     )
 
-    const fetchOnKeyChange = Effect.addFinalizer(() => interrupt).pipe(
-        Effect.andThen(Stream.runForEach(Stream.changes(key), latestKey =>
-            Ref.set(latestKeyRef, Option.some(latestKey)).pipe(
-                Effect.andThen(forkFetch)
-            )
-        ))
-    )
-
     return {
-        context,
-
+        queryKey: key,
         latestKeyRef,
         stateRef,
         fiberRef,
 
+        interrupt,
         forkInterrupt,
         forkFetch,
         forkRefresh,
-
-        fetchOnKeyChange,
     }
 })
 
@@ -193,5 +188,11 @@ export const run = <K extends readonly unknown[], A, E>(
     if (typeof window !== "undefined" && (options?.refreshOnWindowFocus ?? true))
         yield* Stream.runForEach(BrowserStream.fromEventListenerWindow("focus"), () => self.forkRefresh)
 
-    yield* self.fetchOnKeyChange
+    yield* Effect.addFinalizer(() => self.interrupt).pipe(
+        Effect.andThen(Stream.runForEach(Stream.changes(self.queryKey), latestKey =>
+            Ref.set(self.latestKeyRef, Option.some(latestKey)).pipe(
+                Effect.andThen(self.forkFetch)
+            )
+        ))
+    )
 })
diff --git a/packages/extension-query/src/QueryService.ts b/packages/extension-query/src/QueryService.ts
deleted file mode 100644
index 4864361..0000000
--- a/packages/extension-query/src/QueryService.ts
+++ /dev/null
@@ -1,7 +0,0 @@
-import { Effect } from "effect"
-import * as QueryRunner from "./QueryRunner.js"
-
-
-export const Tag = <const Id extends string>(id: Id) => <
-    Self, K extends readonly unknown[], A, E = never
->() => Effect.Tag(id)<Self, QueryRunner.QueryRunner<K, A, E>>()
diff --git a/packages/extension-query/src/index.ts b/packages/extension-query/src/index.ts
index 67d26d3..b86b17b 100644
--- a/packages/extension-query/src/index.ts
+++ b/packages/extension-query/src/index.ts
@@ -4,4 +4,3 @@ export * as QueryErrorHandler from "./QueryErrorHandler.js"
 export * from "./QueryExtension.js"
 export * as QueryProgress from "./QueryProgress.js"
 export * as QueryRunner from "./QueryRunner.js"
-export * as QueryService from "./QueryService.js"